chore: remove unused S3 SignatureVersion setting#39244
chore: remove unused S3 SignatureVersion setting#39244ricardogarim wants to merge 2 commits intochore/aws-sdk-v3from
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (55)
💤 Files with no reviewable changes (46)
✅ Files skipped from review due to trivial changes (2)
📜 Recent review details⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
🧰 Additional context used🧠 Learnings (2)📓 Common learnings📚 Learning: 2025-11-19T12:32:29.696ZApplied to files:
🔇 Additional comments (7)
WalkthroughRemoved the FileUpload_S3_SignatureVersion setting and its usage from the Amazon S3 connection config and settings definition; removed the corresponding translation key from all locale files. Changes align with removing the S3 signatureVersion option (related to the AWS SDK migration). Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## chore/aws-sdk-v3 #39244 +/- ##
=================================================
Coverage 70.72% 70.72%
=================================================
Files 3195 3195
Lines 113106 113105 -1
Branches 20493 20512 +19
=================================================
+ Hits 79991 79997 +6
- Misses 31065 31066 +1
+ Partials 2050 2042 -8
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
KevLehman
left a comment
KevLehman
left a comment
There was a problem hiding this comment.
I kinda remember that if you remove the english translation, then all the other translations would be removed by lingohub at the next update 👀 (for the future)
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
ricardogarim
force-pushed
the
chore/remove-s3-signatureversion-setting
branch
from
55f2e1b to
c84b6d3
Compare
2 participants
Proposed changes (including videos or screenshots)
The AWS SDK v3 S3 client always uses Signature Version 4 and no longer accepts a configurable signature version, so this setting had become a no-op.
Issue(s)
Steps to test or reproduce
Further comments
Summary by CodeRabbit